Contributions

Every frontend controller had to extend AbstractAction, which made the class hierarchy the only extension point. Dispatching of controller_predispatch moved into a plugin, so a controller now only has to implement ActionInterface. 44 files, and the start of the whole controller decomposition effort with Vinai Kopp and Lena Orobei.

With image_width and image_height missing from the image parameters, getRatio produced a fatal error rather than a missing thumbnail. Values now fall back to zero, covered by a unit test.

Every variation of a configurable product collapsed into one row, so a merchant could see the product sold but never which size or colour. Grouping by SKU, with an index added to keep the query in check.

foreach () { $x = array_merge($x, ...); } reallocates the whole array on every iteration — quadratic by construction. Rewritten across 42 files.

Integration runs failed intermittently with Call to a member function findFile() on array whenever the autoloader had not been registered as expected. The kind of flake that gets rerun for months instead of read.

ConsumerRunnerTest took 30.002 seconds, of which 30 were a hardcoded sleep. The interval is now injected and set to zero in the test — everyone running the unit suite locally got those 30 seconds back.

Reindex logged a padded multi-line warning per missing attribute, so every entry was a unique string and no log tool could group them. Short message, attribute id and entity type moved into the log context.

Every CLI run — reindex, cron, import — landed in New Relic under one anonymous transaction, so you could see that something was slow but never which command. Now the command name is the transaction name.

An admin whose role had no resources assigned got redirected from adminhtml/index to adminhtml/noroute/denied — a page they also could not access, so the browser bounced forever. Skipping the request key check for the error page lets the denial actually render.