Contributions
Shaping the tools I use every day, one pull request at a time
A hand-picked selection: only the contributions worth reading about, not every merged pull request.
Handle negative page numbers on category listings — on GitHub
A negative ?p= value was treated as a valid request and ended in an exception instead of a sensible response — trivially reachable by any crawler that guesses at URLs.
Fix customer data when a form contains a field named "method" — on GitHub
customer-data.js read event.target.method to check the form method — but with an input named method in the form, that resolves to the element, not the attribute. Two lines, one very confusing class of checkout bugs.
Use the hex-tag JSON serializer for data embedded in templates — on GitHub
A User module view model serialized data for output with the plain JSON serializer, which breaks the moment the content carries markup — precisely the case JsonHexTag exists for.
Make checkout failure logs groupable by reason, not quote ID — on GitHub
The quote ID was baked into the log message, so Kibana, New Relic and Sentry each saw every checkout failure as a unique event and aggregated nothing. Event data moved to the PSR-3 context, leaving a stable message to group on.
Stop setup:install hanging in integration test runs — on GitHub
Any prompt raised during install left the test bootstrap waiting for an answer nobody could type, so CI hung until it timed out. --no-interaction turns that into a clean failure.
Remove the redundant COUNT() call on the first page of results — on GitHub
Every paginated grid calculated the last page number so it could redirect out-of-range requests — including when you were already on page one. Admin category edit was one of many pages paying for it.
Introduce BlockByIdentifier for CMS blocks — on GitHub
The old CMS block widget loaded through AbstractModel::load and returned the same cache identity regardless of store scope — so one identifier reused across store views served the wrong content. A new class rather than a breaking change to the old one.
Drop a redundant DB query from cart price rule validation — on GitHub
The sales rule validator ran a raw SQL query per item while the same data was already available through the data provider it held. Loading data in a loop — no, thank you. Measurable win on checkout with 20+ products in the cart.
Deprecate the ObjectManager helper in unit tests — on GitHub
The test helper auto-mocked every dependency, which hid how bloated a class had grown and let backwards-incompatible constructor changes pass a green suite. Plain new makes both visible at the moment they happen.
Only merged work is listed here, and only the parts worth a comment — the full history, including everything still in review, lives on GitHub.
Join the Inner Circle
The
compiled_configcache holds the mergeddi.xmlgraph, and integration tests rebuilt it instead of reusing it. Straight wall-clock off every suite run.