Contributions
Shaping the tools I use every day, one pull request at a time
A hand-picked selection: only the contributions worth reading about, not every merged pull request. Articles about Magento and Adobe Commerce are on the blog.
Introduce BlockByIdentifier for CMS blocks — on GitHub
The old CMS block widget loaded through AbstractModel::load and returned the same cache identity regardless of store scope — so one identifier reused across store views served the wrong content. A new class rather than a breaking change to the old one.
Extract request-to-model mapping into a hydrator — on GitHub
Adding one field to a menu meant inheriting the whole Save controller. With a hydrator service, an after plugin is enough.
Drop a redundant DB query from cart price rule validation — on GitHub
The sales rule validator ran a raw SQL query per item while the same data was already available through the data provider it held. Loading data in a loop — no, thank you. Measurable win on checkout with 20+ products in the cart.
Deprecate the ObjectManager helper in unit tests — on GitHub
The test helper auto-mocked every dependency, which hid how bloated a class had grown and let backwards-incompatible constructor changes pass a green suite. Plain new makes both visible at the moment they happen.
Stop re-reading cache config on every layout call — on GitHub
Two lines: PageCache and Layout each fetched the cache configuration repeatedly on the same request. Small change, hit on every single page load.
Move an application plugin out of the framework namespace — on GitHub
A plugin had been sitting inside Magento\Framework since 2016, against Magento’s own architecture rules, and no static check ever noticed. Relocated to the Theme module where application-level interception belongs.
Fix MAGENTO_BACKEND_BASE_URL being ignored — on GitHub
Admin steps used amOnPage, which ignores a separate backend domain, so anyone running the admin on its own host could not run the suite. Switched to amOnUrl and put URL resolution in one class instead of five.
Replace blacklist/whitelist with allow and deny lists — on GitHub
32 files of naming that carried baggage nobody needed. Not every occurrence could be renamed without breaking backward compatibility, but the core of it moved.
Improve the Interceptor generator — on GitHub
Generated interceptors carried a redundant } else { branch in every plugin-wrapped method — thousands of classes worth of dead structure. Cleaned the template with no cost to setup:di:compile time.
Only merged work is listed here, and only the parts worth a comment — the full history, including everything still in review, lives on GitHub.
Join the Inner Circle
Blackfire showed the same database call executed three times while rendering a category page. Kept the result in an object cache for the request.